Skip to content

Commit 6620c4c

Browse files
committed
chore: remove h2 request handler codegen for Kinesis
1 parent 080efeb commit 6620c4c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddHttp2Dependency.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
4141

4242
private static boolean isHttp2Applicable(ServiceShape service) {
4343
String serviceId = service.getTrait(ServiceTrait.class).map(ServiceTrait::getSdkId).orElse("");
44-
return serviceId.equals("Transcribe Streaming") || serviceId.equals("Kinesis");
44+
// TODO: Add "Kinesis" service to http2 applicable, but blocked by potential breaking change.
45+
// Reference: https://github.com/aws/aws-sdk-js-v3/issues/1206
46+
return serviceId.equals("Transcribe Streaming");
4547
}
4648
}

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsDependency.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ public enum AwsDependency implements SymbolDependencyContainer {
5757
UUID_GENERATOR(NORMAL_DEPENDENCY, "uuid", "^7.0.0"),
5858
UUID_GENERATOR_TYPES(DEV_DEPENDENCY, "@types/uuid", "^7.0.0"),
5959
MIDDLEWARE_EVENTSTREAM(NORMAL_DEPENDENCY, "@aws-sdk/middleware-eventstream", "^1.0.0-beta.0"),
60-
AWS_SDK_EVENTSTREAM_HANDLER_NODE(NORMAL_DEPENDENCY, "@aws-sdk/eventstream-handler-node", "^1.0.0-beta.0"),
61-
TRANSCRIBESTREAMING_MIDDLEWARE(NORMAL_DEPENDENCY, "@aws-sdk/eventstream-handler", "^1.0.0-beta.0");
60+
AWS_SDK_EVENTSTREAM_HANDLER_NODE(NORMAL_DEPENDENCY, "@aws-sdk/eventstream-handler-node", "^1.0.0-beta.0");
6261

6362
public final String packageName;
6463
public final String version;

0 commit comments

Comments
 (0)