fix(smithy-client): exception option missing message property (#3424)

Co-authored-by: Eduardo Rodrigues <[email protected]>

Author: eduardomourar

packages/smithy-client/src/exceptions.spec.ts

@@ -1,4 +1,4 @@
-import { decorateServiceException, ServiceException } from "./exceptions";
+import { decorateServiceException, ExceptionOptionType, ServiceException } from "./exceptions";
 
 it("ServiceException extends from Error", () => {
   expect(
@@ -11,6 +11,27 @@ it("ServiceException extends from Error", () => {
   ).toBeInstanceOf(Error);
 });
 
+it("ExceptionOptionType allows specifying message", () => {
+  class SomeException extends ServiceException {
+    readonly code: string;
+    constructor(opts: ExceptionOptionType<SomeException, ServiceException>) {
+      super({
+        name: "SomeException",
+        $fault: "client",
+        ...opts,
+      });
+      this.code = opts.code;
+    }
+  }
+  const exception = new SomeException({
+    message: "message",
+    code: "code",
+    $metadata: {},
+  });
+  expect(exception.message).toBe("message");
+  expect(exception.code).toBe("code");
+});
+
 describe("decorateServiceException", () => {
   const exception = new ServiceException({
     name: "Error",

packages/smithy-client/src/exceptions.ts

@@ -3,12 +3,12 @@ import { HttpResponse, MetadataBearer, ResponseMetadata, RetryableTrait, SmithyE
 /**
  * The type of the exception class constructor parameter. The returned type contains the properties
  * in the `ExceptionType` but not in the `BaseExceptionType`. If the `BaseExceptionType` contains
- * `$metadata` property, it's also included in the returned type.
+ * `$metadata` and `message` properties, it's also included in the returned type.
  * @internal
  */
 export type ExceptionOptionType<ExceptionType extends Error, BaseExceptionType extends Error> = Omit<
   ExceptionType,
-  Exclude<keyof BaseExceptionType, "$metadata">
+  Exclude<keyof BaseExceptionType, "$metadata" | "message">
 >;
 
 export interface ServiceExceptionOptions extends SmithyException, MetadataBearer {