fix(smithy-client): exception option missing message property #3424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AllanZhengYP , could you help with this PR, please? It is a small change that is blocking me. |
AllanZhengYP
previously approved these changes
Mar 28, 2022
|
@eduardomourar Thanks for the PR! It looks good to me. The SSDK CI is failing, likely due to the updated TypeScript version. I cannot reproduce it with the latest main branches. Can you try rebasing it? |
eduardomourar
force-pushed
the
fix/exception-option-message
branch
from
e811a43 to
4400638
Compare
|
@AllanZhengYP, rebase done |
eduardomourar
force-pushed
the
fix/exception-option-message
branch
from
4400638 to
607ffe7
Compare
eduardomourar
force-pushed
the
fix/exception-option-message
branch
from
607ffe7 to
59f2868
Compare
|
@AllanZhengYP , @trivikr or @kuhe , could this PR be merged, please? |
trivikr
approved these changes
Sep 27, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves: #3492
The
messageproperty is being excluded inExceptionOptionType.Description
From the type-system perspective, we were not allowed to pass the message whenever instantiating any Exception generated by the Smithy TypeScript generator.
Testing
Unit test
Additional context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.