Skip to content

Commit b8a8a84

Browse files
Chase Coalwelltrivikr
authored andcommitted
fix: accept header typo (#703)
1 parent 311c7ca commit b8a8a84

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public List<RuntimeClientPlugin> getClientPlugins() {
8282
HAS_MIDDLEWARE)
8383
.build(),
8484
RuntimeClientPlugin.builder()
85-
.withConventions(AwsDependency.ACCEPTS_HEADER.dependency, "AcceptsHeader",
85+
.withConventions(AwsDependency.ACCEPT_HEADER.dependency, "AcceptHeader",
8686
HAS_MIDDLEWARE)
8787
.servicePredicate((m, s) -> testServiceId(s, "API Gateway"))
8888
.build(),

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsDependency.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public enum AwsDependency implements SymbolDependencyContainer {
3131
MIDDLEWARE_SIGNING(NORMAL_DEPENDENCY, "@aws-sdk/middleware-signing", "^1.0.0-alpha.0"),
3232
CREDENTIAL_PROVIDER_NODE(NORMAL_DEPENDENCY, "@aws-sdk/credential-provider-node", "^1.0.0-alpha.0"),
3333
REGION_PROVIDER(NORMAL_DEPENDENCY, "@aws-sdk/region-provider", "^1.0.0-alpha.0"),
34-
ACCEPTS_HEADER(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-api-gateway", "^1.0.0-alpha.0"),
34+
ACCEPT_HEADER(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-api-gateway", "^1.0.0-alpha.0"),
3535
VALIDATE_BUCKET_NAME(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-s3", "^1.0.0-alpha.0"),
3636
ADD_EXPECT_CONTINUE(NORMAL_DEPENDENCY, "@aws-sdk/middleware-expect-continue", "^1.0.0-alpha.0"),
3737
GLACIER_MIDDLEWARE(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-glacier", "^1.0.0-alpha.0"),
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
import { acceptsHeaderMiddleware } from "./index";
1+
import { acceptHeaderMiddleware } from "./index";
22
import { HttpRequest } from "@aws-sdk/protocol-http";
33

4-
describe("acceptsHeaderMiddleware", () => {
4+
describe("acceptHeaderMiddleware", () => {
55
const next = jest.fn();
66

77
beforeEach(() => {
88
jest.clearAllMocks();
99
});
1010

11-
it("sets Accepts header to application/json", async () => {
12-
const handler = acceptsHeaderMiddleware()(next, {} as any);
11+
it("sets Accept header to application/json", async () => {
12+
const handler = acceptHeaderMiddleware()(next, {} as any);
1313
await handler({
1414
input: {},
1515
request: new HttpRequest({
@@ -20,6 +20,6 @@ describe("acceptsHeaderMiddleware", () => {
2020
const { calls } = (next as any).mock;
2121
expect(calls.length).toBe(1);
2222
const { request } = next.mock.calls[0][0];
23-
expect(request.headers["accepts"]).toBe("application/json");
23+
expect(request.headers["accept"]).toBe("application/json");
2424
});
2525
});

packages/middleware-sdk-api-gateway/src/index.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
} from "@aws-sdk/types";
1010
import { HttpRequest } from "@aws-sdk/protocol-http";
1111

12-
export function acceptsHeaderMiddleware(): BuildMiddleware<any, any> {
12+
export function acceptHeaderMiddleware(): BuildMiddleware<any, any> {
1313
return <Output extends MetadataBearer>(
1414
next: BuildHandler<any, Output>
1515
): BuildHandler<any, Output> => async (
@@ -19,7 +19,7 @@ export function acceptsHeaderMiddleware(): BuildMiddleware<any, any> {
1919
if (HttpRequest.isInstance(request)) {
2020
request.headers = {
2121
...request.headers,
22-
accepts: "application/json"
22+
accept: "application/json"
2323
};
2424
}
2525
return next({
@@ -29,14 +29,14 @@ export function acceptsHeaderMiddleware(): BuildMiddleware<any, any> {
2929
};
3030
}
3131

32-
export const acceptsHeaderMiddlewareOptions: BuildHandlerOptions = {
32+
export const acceptHeaderMiddlewareOptions: BuildHandlerOptions = {
3333
step: "build",
34-
tags: ["SET_ACCEPTS_HEADER", "ACCEPTS_HEADER"],
35-
name: "acceptsHeaderMiddleware"
34+
tags: ["SET_ACCEPT_HEADER", "ACCEPT_HEADER"],
35+
name: "acceptHeaderMiddleware"
3636
};
3737

3838
export const getAcceptsHeaderPlugin = (unused: any): Pluggable<any, any> => ({
3939
applyToStack: clientStack => {
40-
clientStack.add(acceptsHeaderMiddleware(), acceptsHeaderMiddlewareOptions);
40+
clientStack.add(acceptHeaderMiddleware(), acceptHeaderMiddlewareOptions);
4141
}
4242
});

0 commit comments

Comments
 (0)