Skip to content

fix: accept header typo #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 9, 2020

Fixes Middleware for API Gateway to set the "accept" header, required to return the necessary content-type.
MDN for Accept header https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from trivikr January 9, 2020 23:45
@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Jan 9, 2020
@aws-sdk-js-automation

This comment has been minimized.

@srchase srchase force-pushed the fix-accept-header branch from be4c0f4 to 222e4f6 Compare January 9, 2020 23:57
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit b8a8a84 into aws:smithy-codegen Jan 10, 2020
@srchase srchase deleted the fix-accept-header branch January 10, 2020 00:41
@lock
Copy link

lock bot commented Jan 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants