Skip to content

fix: accept header typo #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2020
Merged

fix: accept header typo #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public List<RuntimeClientPlugin> getClientPlugins() {
HAS_MIDDLEWARE)
.build(),
RuntimeClientPlugin.builder()
.withConventions(AwsDependency.ACCEPTS_HEADER.dependency, "AcceptsHeader",
.withConventions(AwsDependency.ACCEPT_HEADER.dependency, "AcceptHeader",
HAS_MIDDLEWARE)
.servicePredicate((m, s) -> testServiceId(s, "API Gateway"))
.build(),
Expand Down
2 changes: 1 addition & 1 deletion ...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsDependency.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public enum AwsDependency implements SymbolDependencyContainer {
MIDDLEWARE_SIGNING(NORMAL_DEPENDENCY, "@aws-sdk/middleware-signing", "^1.0.0-alpha.0"),
CREDENTIAL_PROVIDER_NODE(NORMAL_DEPENDENCY, "@aws-sdk/credential-provider-node", "^1.0.0-alpha.0"),
REGION_PROVIDER(NORMAL_DEPENDENCY, "@aws-sdk/region-provider", "^1.0.0-alpha.0"),
ACCEPTS_HEADER(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-api-gateway", "^1.0.0-alpha.0"),
ACCEPT_HEADER(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-api-gateway", "^1.0.0-alpha.0"),
VALIDATE_BUCKET_NAME(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-s3", "^1.0.0-alpha.0"),
ADD_EXPECT_CONTINUE(NORMAL_DEPENDENCY, "@aws-sdk/middleware-expect-continue", "^1.0.0-alpha.0"),
GLACIER_MIDDLEWARE(NORMAL_DEPENDENCY, "@aws-sdk/middleware-sdk-glacier", "^1.0.0-alpha.0"),
Expand Down
10 changes: 5 additions & 5 deletions packages/middleware-sdk-api-gateway/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { acceptsHeaderMiddleware } from "./index";
import { acceptHeaderMiddleware } from "./index";
import { HttpRequest } from "@aws-sdk/protocol-http";

describe("acceptsHeaderMiddleware", () => {
describe("acceptHeaderMiddleware", () => {
const next = jest.fn();

beforeEach(() => {
jest.clearAllMocks();
});

it("sets Accepts header to application/json", async () => {
const handler = acceptsHeaderMiddleware()(next, {} as any);
it("sets Accept header to application/json", async () => {
const handler = acceptHeaderMiddleware()(next, {} as any);
await handler({
input: {},
request: new HttpRequest({
Expand All @@ -20,6 +20,6 @@ describe("acceptsHeaderMiddleware", () => {
const { calls } = (next as any).mock;
expect(calls.length).toBe(1);
const { request } = next.mock.calls[0][0];
expect(request.headers["accepts"]).toBe("application/json");
expect(request.headers["accept"]).toBe("application/json");
});
});
12 changes: 6 additions & 6 deletions packages/middleware-sdk-api-gateway/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from "@aws-sdk/types";
import { HttpRequest } from "@aws-sdk/protocol-http";

export function acceptsHeaderMiddleware(): BuildMiddleware<any, any> {
export function acceptHeaderMiddleware(): BuildMiddleware<any, any> {
return <Output extends MetadataBearer>(
next: BuildHandler<any, Output>
): BuildHandler<any, Output> => async (
Expand All @@ -19,7 +19,7 @@ export function acceptsHeaderMiddleware(): BuildMiddleware<any, any> {
if (HttpRequest.isInstance(request)) {
request.headers = {
...request.headers,
accepts: "application/json"
accept: "application/json"
};
}
return next({
Expand All @@ -29,14 +29,14 @@ export function acceptsHeaderMiddleware(): BuildMiddleware<any, any> {
};
}

export const acceptsHeaderMiddlewareOptions: BuildHandlerOptions = {
export const acceptHeaderMiddlewareOptions: BuildHandlerOptions = {
step: "build",
tags: ["SET_ACCEPTS_HEADER", "ACCEPTS_HEADER"],
name: "acceptsHeaderMiddleware"
tags: ["SET_ACCEPT_HEADER", "ACCEPT_HEADER"],
name: "acceptHeaderMiddleware"
};

export const getAcceptsHeaderPlugin = (unused: any): Pluggable<any, any> => ({
applyToStack: clientStack => {
clientStack.add(acceptsHeaderMiddleware(), acceptsHeaderMiddlewareOptions);
clientStack.add(acceptHeaderMiddleware(), acceptHeaderMiddlewareOptions);
}
});