Skip to content

feat: protocol test codegen project + service clients #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Mar 27, 2020

Add project for protocol test codegen

This commit adds a separate Gradle project that depends on the
published version of the smithy-aws-protocol-tests. This new project
contains 1 projection for each protocol, generating the full AWS SDK
for JS V3 client and test suite for each contained service.

Add generated protocol tests

This commit adds the protocol tests generated by the protocol-test-codegen
project to the repository. It enables their building and running through
the use of new package level commands, build:protocols and test:protocols.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 27, 2020

Codecov Report

Merging #1058 into master will decrease coverage by 13.99%.
The diff coverage is 73.65%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1058     +/-   ##
=========================================
- Coverage   91.43%   77.44%    -14%     
=========================================
  Files         145      279    +134     
  Lines        2850    11552   +8702     
  Branches      506     2291   +1785     
=========================================
+ Hits         2606     8946   +6340     
- Misses        244     2606   +2362
Impacted Files Coverage Δ
...sts/aws-restxml/commands/FlattenedXmlMapCommand.ts 100% <ø> (ø)
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 100% <ø> (ø)
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 100% <ø> (ø)
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 100% <ø> (ø)
...sts/aws-restjson/commands/JsonTimestampsCommand.ts 100% <ø> (ø)
...ests/aws-restxml/commands/XmlMapsXmlNameCommand.ts 100% <ø> (ø)
protocol_tests/aws-restxml/endpoints.ts 82.14% <ø> (ø)
...stxml/commands/InputAndOutputWithHeadersCommand.ts 100% <ø> (ø)
...aws-restxml/commands/AllQueryStringTypesCommand.ts 88.23% <ø> (ø)
...aws-restjson/commands/NoInputAndNoOutputCommand.ts 100% <ø> (ø)
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6667e3a...da54750. Read the comment docs.

@aws-sdk-js-automation

This comment has been minimized.

This commit adds a separate Gradle project that depends on the
published version of the smithy-aws-protocol-tests. This new project
contains 1 projection for each protocol, generating the full AWS SDK
for JS V3 client and test suite for each contained service.
@kstich kstich force-pushed the add_protocol_test_codegen branch from e57acd2 to 68bfe89 Compare April 1, 2020 00:09
@aws-sdk-js-automation

This comment has been minimized.

@kstich kstich force-pushed the add_protocol_test_codegen branch from 68bfe89 to be0dabd Compare April 1, 2020 18:35
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: be0dabd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kstich kstich requested review from trivikr and removed request for mtdowling and AllanZhengYP April 1, 2020 18:51
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nits

@trivikr trivikr self-requested a review April 2, 2020 16:12
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments posted in previous review

This commit adds the protocol tests generated by the protocol-test-codegen
project to the repository. It enables their building and running through
the use of new package level commands, build:protocols and test:protocols.
@kstich kstich force-pushed the add_protocol_test_codegen branch from be0dabd to da54750 Compare April 2, 2020 17:36
@kstich kstich requested a review from trivikr April 2, 2020 17:37
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: da54750
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 16f81f6 into aws:master Apr 3, 2020
@kstich kstich deleted the add_protocol_test_codegen branch April 3, 2020 15:57
@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants