-
Notifications
You must be signed in to change notification settings - Fork 618
feat: protocol test codegen project + service clients #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
=========================================
- Coverage 91.43% 77.44% -14%
=========================================
Files 145 279 +134
Lines 2850 11552 +8702
Branches 506 2291 +1785
=========================================
+ Hits 2606 8946 +6340
- Misses 244 2606 +2362
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This commit adds a separate Gradle project that depends on the published version of the smithy-aws-protocol-tests. This new project contains 1 projection for each protocol, generating the full AWS SDK for JS V3 client and test suite for each contained service.
e57acd2
to
68bfe89
Compare
This comment has been minimized.
This comment has been minimized.
68bfe89
to
be0dabd
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments posted in previous review
This commit adds the protocol tests generated by the protocol-test-codegen project to the repository. It enables their building and running through the use of new package level commands, build:protocols and test:protocols.
be0dabd
to
da54750
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Add project for protocol test codegen
This commit adds a separate Gradle project that depends on the
published version of the smithy-aws-protocol-tests. This new project
contains 1 projection for each protocol, generating the full AWS SDK
for JS V3 client and test suite for each contained service.
Add generated protocol tests
This commit adds the protocol tests generated by the protocol-test-codegen
project to the repository. It enables their building and running through
the use of new package level commands,
build:protocols
andtest:protocols
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.