Skip to content

chore(deps-dev): bump cucumber to 6.0.5 #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/autoscaling/step_definitions/autoscaling.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@autoscaling" }, function(scenario, callback) {
callback();
});

Given(/^I create a launch configuration with name "([^"]*)"$/, function(
Given("I create a launch configuration with name {string}", function(
name,
callback
) {
Expand Down
2 changes: 1 addition & 1 deletion features/cloudformation/step_definitions/cloudformation.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@cloudformation" }, function(scenario, callback) {
callback();
});

Given(/^I create a CloudFormation stack with name prefix "([^"]*)"$/, function(
Given("I create a CloudFormation stack with name prefix {string}", function(
prefix,
callback
) {
Expand Down
32 changes: 16 additions & 16 deletions features/cloudfront/step_definitions/cloudfront.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,22 @@ Before({ tags: "@cloudfront" }, function(scenario, callback) {
callback();
});

Given(
/^I create a CloudFront distribution with name prefix "([^"]*)"$/,
function(prefix, callback) {
this.cfName = this.uniqueName(prefix);
this.cfCreateParams.CallerReference = this.cfName;
this.cfCreateParams.Origins.Items[0].Id =
this.cfName === "" ? "origin" : "InvalidOrigin";
this.request(
null,
"createDistribution",
{ DistributionConfig: this.cfCreateParams },
callback,
false
);
}
);
Given("I create a CloudFront distribution with name prefix {string}", function(
prefix,
callback
) {
this.cfName = this.uniqueName(prefix);
this.cfCreateParams.CallerReference = this.cfName;
this.cfCreateParams.Origins.Items[0].Id =
this.cfName === "" ? "origin" : "InvalidOrigin";
this.request(
null,
"createDistribution",
{ DistributionConfig: this.cfCreateParams },
callback,
false
);
});

Given(/^I list CloudFront distributions$/, function(callback) {
this.request(null, "listDistributions", {}, callback);
Expand Down
2 changes: 1 addition & 1 deletion features/cloudsearch/step_definitions/cloudsearch.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@cloudsearch" }, function(scenario, callback) {
callback();
});

Given(/^I create a domain with name prefix "([^"]*)"$/, function(
Given("I create a domain with name prefix {string}", function(
prefix,
callback
) {
Expand Down
28 changes: 22 additions & 6 deletions features/cloudwatch/step_definitions/cloudwatch.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ Before({ tags: "@cloudwatch" }, function(scenario, callback) {
callback();
});

Given(/^I create a CloudWatch alarm with (prefix|name) "([^"]*)"$/, function(
prefix,
Given("I create a CloudWatch alarm with prefix {string}", function(
name,
callback
) {
Expand All @@ -23,19 +22,36 @@ Given(/^I create a CloudWatch alarm with (prefix|name) "([^"]*)"$/, function(
Threshold: 50.0
};

if (prefix === "prefix") {
this.cloudWatchAlarm.AlarmName += "-" + timestamp;
}
this.cloudWatchAlarm.AlarmName += "-" + timestamp;

this.request(
null,
"putMetricAlarm",
this.cloudWatchAlarm,
callback,
prefix === "name" ? false : undefined
undefined
);
});

Given("I create a CloudWatch alarm with name {string}", function(
name,
callback
) {
const timestamp = new Date().getTime();
this.cloudWatchAlarm = {
AlarmName: name,
MetricName: "aws-sdk-js-metric-" + timestamp,
Namespace: "aws-sdk-js-namespace" + timestamp,
ComparisonOperator: "GreaterThanThreshold",
EvaluationPeriods: 5,
Period: 60,
Statistic: "Average",
Threshold: 50.0
};

this.request(null, "putMetricAlarm", this.cloudWatchAlarm, callback, false);
});

Given(/^I list the CloudWatch alarms$/, function(callback) {
const params = {
MetricName: this.cloudWatchAlarm.MetricName,
Expand Down
2 changes: 1 addition & 1 deletion features/cloudwatchlogs/step_definitions/cloudwatchlogs.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@cloudwatchlogs" }, function(scenario, callback) {
callback();
});

Given(/^I create a CloudWatch logGroup with prefix "([^"]*)"$/, function(
Given("I create a CloudWatch logGroup with prefix {string}", function(
prefix,
callback
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@cognitoidentity" }, function(scenario, callback) {
callback();
});

Given(/^I create a Cognito identity pool with prefix "([^"]*)"$/, function(
Given("I create a Cognito identity pool with prefix {string}", function(
prefix,
callback
) {
Expand Down
2 changes: 1 addition & 1 deletion features/datapipeline/step_definitions/datapipeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@datapipeline" }, function(scenario, callback) {
callback();
});

Given(/^I create a Data Pipeline with name prefix "([^"]*)"$/, function(
Given("I create a Data Pipeline with name prefix {string}", function(
prefix,
callback
) {
Expand Down
5 changes: 1 addition & 4 deletions features/ec2/step_definitions/ec2.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,7 @@ Then(/^the EC2 endpoint for "([^"]*)" should be "([^"]*)"$/, function(
callback();
});

Given(/^I describe the EC2 instance "([^"]*)"$/, function(
instanceId,
callback
) {
Given("I describe the EC2 instance {string}", function(instanceId, callback) {
this.request(
null,
"describeInstances",
Expand Down
2 changes: 1 addition & 1 deletion features/elasticache/step_definitions/elasticache.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Before({ tags: "@elasticache" }, function(scenario, callback) {
callback();
});

Given(/^I create a cache parameter group with name prefix "([^"]*)"$/, function(
Given("I create a cache parameter group with name prefix {string}", function(
prefix,
callback
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Before({ tags: "@elasticbeanstalk" }, function(scenario, callback) {
});

Given(
/^I create an Elastic Beanstalk application with name prefix "([^"]*)"$/,
"I create an Elastic Beanstalk application with name prefix {string}",
function(prefix, callback) {
this.appName = this.uniqueName(prefix);
const params = { ApplicationName: this.appName };
Expand All @@ -18,7 +18,7 @@ Given(
);

Given(
/^I create an Elastic Beanstalk application version with label "([^"]*)"$/,
"I create an Elastic Beanstalk application version with label {string}",
function(label, callback) {
this.appVersion = label;
const params = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Before({ tags: "@elastictranscoder" }, function(scenario, callback) {
});

Given(
/^I create an Elastic Transcoder pipeline with name prefix "([^"]*)"$/,
"I create an Elastic Transcoder pipeline with name prefix {string}",
function(prefix, callback) {
this.pipelineName = this.uniqueName(prefix);
const params = {
Expand Down
2 changes: 1 addition & 1 deletion features/rds/step_definitions/rds.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Before({ tags: "@rds" }, function(scenario, callback) {
callback();
});

Given(/^I create a RDS security group with prefix name "([^"]*)"$/, function(
Given("I create a RDS security group with prefix name {string}", function(
prefix,
callback
) {
Expand Down
2 changes: 1 addition & 1 deletion features/redshift/step_definitions/redshift.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Before({ tags: "@redshift" }, function(scenario, callback) {
});

Given(
/^I create a Redshift cluster parameter group with prefix name "([^"]*)"$/,
"I create a Redshift cluster parameter group with prefix name {string}",
function(prefix, callback) {
this.parameterGroupName = this.uniqueName(prefix);
const params = {
Expand Down
2 changes: 1 addition & 1 deletion features/s3/objects.feature
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Feature: Working with Objects in S3

@error
Scenario: Error handling
Given I put "data" to the invalid key ""
Given I put "data" to the key ""
Then the error message should be:
"""
Empty value provided for input HTTP label: Key.
Expand Down
8 changes: 2 additions & 6 deletions features/s3/step_definitions/objects.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ function getSignedUrl(client, command, params, callback) {
});
}

When(/^I put "([^"]*)" to the(?: invalid)? key "([^"]*)"$/, function(
data,
key,
next
) {
When("I put {string} to the key {string}", function(data, key, next) {
const params = {
Bucket: this.sharedBucket,
Key: key,
Expand Down Expand Up @@ -97,7 +93,7 @@ When(
}
);

Then(/^the object "([^"]*)" should contain "([^"]*)"$/, function(
Then("the object {string} should contain {string}", function(
key,
contents,
next
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@types/fs-extra": "^8.0.1",
"@types/jest": "^25.1.4",
"codecov": "^3.4.0",
"cucumber": "5.1.0",
"cucumber": "^6.0.5",
"fs-extra": "^8.1.0",
"generate-changelog": "^1.7.1",
"husky": "^4.2.3",
Expand Down
Loading