Skip to content

chore: use Array shorthand syntax #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 30, 2020

Issue #, if available:

Description of changes:
CodeGen for using Array shorthand syntax

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: d2691b8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #1127 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   73.54%   73.54%   -0.01%     
==========================================
  Files         283      284       +1     
  Lines       13014    13021       +7     
  Branches     3030     3033       +3     
==========================================
+ Hits         9571     9576       +5     
- Misses       3443     3445       +2     
Impacted Files Coverage Δ
packages/util-body-length-browser/src/index.ts 71.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a3658...d2691b8. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to type the array. Looks good to me.

@trivikr trivikr changed the title chore: CodeGen for using Array shorthand syntax chore: codegen for using Array shorthand syntax May 1, 2020
@trivikr trivikr marked this pull request as ready for review May 1, 2020 19:21
@trivikr trivikr changed the title chore: codegen for using Array shorthand syntax chore: use Array shorthand syntax May 1, 2020
@trivikr trivikr merged commit 8ca1e67 into aws:master May 1, 2020
@trivikr trivikr deleted the array-shorthand branch May 1, 2020 19:23
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use short-hand syntax Type[] instead of Array<Type>
4 participants