Skip to content

chore: define query while declaring #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2020
Merged

chore: define query while declaring #1161

merged 1 commit into from
May 11, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 8, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#177

Description of changes:
define query while declaring

Verified that integration tests are successful:

$ AWS_PROFILE=<profile> yarn test:integration
yarn run v1.22.4
$ cucumber-js --fail-fast
..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
...................

153 scenarios (153 passed)
534 steps (534 passed)
0m55.662s
Done in 58.55s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 62d6e0e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@alexforsyth
Copy link
Contributor

LGTM!

@alexforsyth
Copy link
Contributor

Nice clean up

alexforsyth
alexforsyth approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@trivikr trivikr marked this pull request as ready for review May 11, 2020 17:53
@trivikr trivikr merged commit 2665c30 into aws:master May 11, 2020
@trivikr trivikr deleted the define-query-declaration branch May 11, 2020 17:54
@trivikr trivikr mentioned this pull request May 12, 2020
Merged
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexforsyth alexforsyth alexforsyth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivikr @aws-sdk-js-automation @alexforsyth