Skip to content

fix: update array to SetShape in protocol_tests #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 11, 2020

Issue #, if available:

Description of changes:
Update array to SetShape in protocol_tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #1170 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
- Coverage   73.96%   73.69%   -0.28%     
==========================================
  Files         285      285              
  Lines       12722    12549     -173     
  Branches     2812     2814       +2     
==========================================
- Hits         9410     9248     -162     
+ Misses       3312     3301      -11     
Impacted Files Coverage Δ
protocol_tests/aws-ec2/models/index.ts 70.12% <ø> (ø)
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 63.81% <ø> (-0.58%) ⬇️
protocol_tests/aws-json/protocols/Aws_json1_1.ts 68.36% <ø> (-0.96%) ⬇️
protocol_tests/aws-query/models/index.ts 70.32% <ø> (ø)
protocol_tests/aws-query/protocols/Aws_query.ts 68.91% <ø> (-0.56%) ⬇️
protocol_tests/aws-restjson/models/index.ts 69.81% <ø> (ø)
...ol_tests/aws-restjson/protocols/Aws_restJson1_1.ts 64.56% <ø> (-0.99%) ⬇️
protocol_tests/aws-restxml/models/index.ts 68.53% <ø> (ø)
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 67.80% <ø> (-0.69%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd0678...8db0d14. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 8db0d14
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 1414b8c into aws:master May 11, 2020
@trivikr trivikr deleted the remove-new-set-protocol-tests branch May 11, 2020 23:19
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants