chore: change Object.keys to Object.entries

[trivikr]

Issue #, if available:
N/A

Description of changes:

• change Object.keys to Object.entries so that object doesn't have to be called in arrow function
• also added type-checks for accumulators
• also used destructuring assignment inside reduce

serializer

• Before

const serializeAws_restJson1_1FilterCriteriaMap = (
  input: { [key: string]: Criterion },
  context: __SerdeContext
): any => {
  return Object.keys(input).reduce((acc: any, key: string) => {
    acc[key] = serializeAws_restJson1_1Criterion(input[key], context);
    return acc;
  }, {});
};

• After

const serializeAws_restJson1_1FilterCriteriaMap = (
  input: { [key: string]: Criterion },
  context: __SerdeContext
): any => {
  return Object.entries(input).reduce(
    (acc: { [key: string]: Criterion }, [key, value]: [string, any]) => ({
      ...acc,
      [key]: serializeAws_restJson1_1Criterion(value, context)
    }),
    {}
  );
};

deserializer

• Before

const deserializeAws_restJson1_1ConditionKeyMap = (
  output: any,
  context: __SerdeContext
): { [key: string]: string } => {
  return Object.keys(output).reduce((acc: any, key: string) => {
    acc[key] = output[key];
    return acc;
  }, {});
};

• After

const deserializeAws_restJson1_1ConditionKeyMap = (
  output: any,
  context: __SerdeContext
): { [key: string]: string } => {
  return Object.entries(output).reduce(
    (acc: { [key: string]: string }, [key, value]: [string, any]) => ({
      ...acc,
      [key]: value
    }),
    {}
  );
};

buildFormUrlencodedString

• Before

const buildFormUrlencodedString = (entries: any): string =>
  Object.keys(entries)
    .map(
      key =>
      ([key, value]) =>
        __extendedEncodeURIComponent(key) +
        "=" +
        __extendedEncodeURIComponent(entries[key])
    )
    .join("&");

• After

const buildFormUrlencodedString = (formEntries: {
  [key: string]: string;
}): string =>
  Object.entries(formEntries)
    .map(
      ([key, value]) =>
        __extendedEncodeURIComponent(key) +
        "=" +
        __extendedEncodeURIComponent(value)
    )
    .join("&");

memberEntries

• Before

    Object.keys(memberEntries).forEach(key => {
      const loc = `ScalingParameters.${key}`;
      entries[loc] = memberEntries[key];
    });

    Object.keys(memberEntries).forEach(key => {
      entries[`member.${counter}.${key}`] = memberEntries[key];

• After

    Object.entries(memberEntries).forEach(([key, value]) => {
      const loc = `ScalingParameters.${key}`;
      entries[loc] = value;
    });

    Object.entries(memberEntries).forEach(([key, value]) => {
      entries[`member.${counter}.${key}`] = value;
    });

return statements in some deserialize functions

• Before

  const key = Object.keys(output)[0];
  return { $unknown: [key, output[key]] };

• After

  return { $unknown: Object.entries(output)[0] };

---

Verified that integration tests are successful:

$ AWS_PROFILE=<profile> yarn test:integration                                                                                         
yarn run v1.22.4
$ cucumber-js --fail-fast
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

153 scenarios (153 passed)
534 steps (534 passed)
0m56.560s
Done in 59.43s.

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• CodeBuild project: sdk-staging-test
• Commit ID: 30a51f6
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[alexforsyth]

LGTM

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.