Feature/base64 support #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be rebased after #11 is merged in. |
chrisradek
approved these changes
Jun 27, 2017
| const bitsPerByte = 8; | ||
| const maxLetterValue = 0b111111; | ||
|
|
||
| export function fromBase64(input: string): Uint8Array { |
There was a problem hiding this comment.
Were these methods taken from somewhere, or was https://tools.ietf.org/html/rfc4648#section-4 used for the spec? We might want to add a comment reference to the spec for future devs (or in the README)
There was a problem hiding this comment.
This was based on the spec. I added some documentation blocks for each encoder, and the browser ones include a link to the IETF spec.
|
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cross-platform base64 support, since this isn't something built into the ES spec. In node, this functionality is provided by the
buffermodule, but we're on our own in browserland. For simplicity, this PR does not include support for URL-safe or unpadded b64, as that can be added as a post-processing step if we ever need it in an SDK.