Skip to content

chore: add missing throttling errors #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 26, 2020

Issue #, if available:
Internally documented in JS-1810

Description of changes:
The existing list of Throttling errors was added in Dec 2017 ae1aa48

  • Missed throttling errors added in this PR:
    • TransactionInProgressException
    • LimitExceededException
    • EC2ThrottledException
  • PriorRequestNotComplete is moved from StillProcessingError to ThrottlingError
    • The API isStillProcessingError is being removed. It's internally only used in retryDecider, and low-level to be not used by pre-release users.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: d702800
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr requested a review from AllanZhengYP May 27, 2020 16:49
@trivikr trivikr merged commit 7e7ee6e into aws:master May 28, 2020
@trivikr trivikr deleted the update-throttling-errors branch May 28, 2020 20:52
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants