chore: deprecate util-base64-universal,util-utf8-universal,is-node #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Jun 5, 2020
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this pull request
Jun 5, 2020
It was not being used, and was getting deprecated. aws/aws-sdk-js-v3#1241 aws/aws-sdk-js-v3#1240?
1 task
seebees
added a commit
to aws/aws-encryption-sdk-javascript
that referenced
this pull request
Jun 5, 2020
It was not being used, and was getting deprecated. aws/aws-sdk-js-v3#1241 aws/aws-sdk-js-v3#1240?
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Deprecate 3 packages bellow:
The deprecated
xxx-universalpackages have both dependency overxxx-nodeandxxx-browserand cannot be tree-shaken. So replace them with direct dependencies over runtime specifc dependencies.This change won't break the SDK because the deprecated
xxx-universalpackages are only used unit tests./cc @seebees
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.