Skip to content

chore: move karma related devdeps to repo root #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes:
This change remove karma/puppeteer related dependencies to project root so that individual package(fetch-http-handler, hash-blob-browser) doesn't come with chunky dependencies. So it accelerates the installation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from trivikr June 24, 2020 00:55
@codecov-commenter
Copy link

Codecov Report

Merging #1292 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
+ Coverage   73.04%   73.17%   +0.13%     
==========================================
  Files         287      290       +3     
  Lines       12730    12792      +62     
  Branches     2922     2936      +14     
==========================================
+ Hits         9299     9361      +62     
  Misses       3431     3431              
Impacted Files Coverage Δ
clients/client-s3/S3Client.ts 94.11% <0.00%> (ø)
clients/client-s3/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/region-provider/src/fromEnv.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/property-provider/src/memoize.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 92.30% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3fdc0...ff3c7e3. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit bddeb3d into master Jun 25, 2020
@AllanZhengYP AllanZhengYP deleted the AllanFly120/move-karma-deps branch June 25, 2020 16:48
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants