Skip to content

chore(credential-provider-imds): providerConfigFromInit arrow function #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 1, 2020

Issue #, if available:
N/A

Description of changes:
converts providerConfigFromInit to an arrow function, and add a comment about DEFAULT_MAX_RETRIES

  • DEFAULT_MAX_RETRIES is 0, as it's the default in AWS SDK for Python and CLI (code)
  • AWS SDK for JavaScript v2 has two attempts though (code)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1315 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         286      286           
  Lines       11899    11899           
  Branches     2600     2601    +1     
=======================================
  Hits         9221     9221           
  Misses       2678     2678           
Impacted Files Coverage Δ
...ider-imds/src/remoteProvider/RemoteProviderInit.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea8e73...d735a50. Read the comment docs.

@trivikr trivikr merged commit e75fe71 into aws:master Jul 6, 2020
@trivikr trivikr deleted the update-imds-default-max-retries branch July 6, 2020 22:43
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants