Add timestamp formatting package for use across multiple serializers #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
chrisradek
reviewed
Jun 5, 2017
packages/protocol-timestamp/index.ts
Outdated
| return Math.floor(toDate(time).valueOf() / 1000); | ||
| } | ||
|
|
||
| function toDate(time: number|string|Date): Date { |
There was a problem hiding this comment.
Can we add tests for toDate as well?
We should make sure we can convert from the 3 timestamp formats back to Date objects.
…hallers/unmarshallers
trivikr
referenced
this pull request
in trivikr/aws-sdk-js-v3
Dec 10, 2018
Add timestamp formatting package for use across multiple serializers
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the timestamp formats used by various serializers and parsers.