Add random source modules for node, browsers, and cross-platform usage #19
Conversation
|
|
||
| describe('implementation selection', () => { | ||
| it('should use the node implementation in node', async () => { | ||
| (isNode as any).mockReturnValue(true); |
There was a problem hiding this comment.
It looks like mockReturnValue may be deprecated
https://facebook.github.io/jest/docs/mock-function-api.html#mockfnmockreturnvaluevalue
That said, I'm not convinced by the docs that their suggested alternative is what we want. mockImplementation might work... I'm also fine with sticking to a major version of jest if this method gets removed.
There was a problem hiding this comment.
I think mockImplementation would be the way to go. I think we should keep updating jest until everything goes GA, so I'm willing to remove uses of deprecated functions until then.
|
Per our discussion re: |
#19) * Add random source modules for node, browsers, and cross-platform usage * Use util-locate-window instead of directly dereferencing "self"
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This PR adds support for getting cryptographically secure random values (necessary for v4 UUIDs and any future encryption modules) from the WebCrypto APIs in supported browsers (including IE 11), from the
cryptomodule in node, and from the SJCL everywhere else.