-
Notifications
You must be signed in to change notification settings - Fork 618
fix(clients): generate jest.config.js instead of extending from global config #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The transpiled files are now stored in dist folder .gitignore for *.js files is not required
5edcd8d
to
67293a9
Compare
48ce3c9
to
1150c2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2163 +/- ##
=======================================
Coverage ? 48.48%
=======================================
Files ? 551
Lines ? 34135
Branches ? 8446
=======================================
Hits ? 16552
Misses ? 17583
Partials ? 0 Continue to review full report at Codecov.
|
Reason: to avoid types clash between jest and mocha
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The test failing on CI is successful in local workspace. |
Superceded by #2172 because of issues with replacing mocha with jest in client-s3. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Refs: #1618
Description
Generate jest.config.js per client instead of extending from global config
Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.