add process credentials provider #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
process-credentials
branch
from
8bb3767 to
9469034
Compare
|
@srchase Just a reminder: You can rebase this PR(and others) to make the checks pass. UPDATE: the check fails because of the missing the trailing empty line in the root package.json. You can ignore it |
| accessKeyId, | ||
| secretAccessKey, | ||
| sessionToken | ||
| }; |
There was a problem hiding this comment.
Just one last comment: Do you really need the branching here? I believe the expiration is optional, so it's ok to be undefined. Just using one return will make the code cleaner
AllanZhengYP
approved these changes
May 1, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add process credential provider
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.