Skip to content

fix(codegen): pass settings to createSymbolProvider #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix(codegen): pass settings to createSymbolProvider #2196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .../test/java/software/amazon/smithy/aws/typescript/codegen/AwsServiceIdIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ public void testSomeLibraryMethod() {
.unwrap();
Shape service = model.expectShape((ShapeId.from("smithy.example#OriginalName")));
AwsServiceIdIntegration integration = new AwsServiceIdIntegration();
SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model);
SymbolProvider decorated = integration.decorateSymbolProvider(
new TypeScriptSettings(), model, provider);
TypeScriptSettings settings = new TypeScriptSettings();
SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model, settings);
SymbolProvider decorated = integration.decorateSymbolProvider(settings, model, provider);
Symbol symbol = decorated.toSymbol(service);

assertThat(symbol.getName(), equalTo("NotSameClient"));
Expand All @@ -44,9 +44,9 @@ public void testFirstNotCapitalizedServiceId() {
.unwrap();
Shape service = model.expectShape((ShapeId.from("smithy.example#OriginalName")));
AwsServiceIdIntegration integration = new AwsServiceIdIntegration();
SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model);
SymbolProvider decorated = integration.decorateSymbolProvider(
new TypeScriptSettings(), model, provider);
TypeScriptSettings settings = new TypeScriptSettings();
SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model, settings);
SymbolProvider decorated = integration.decorateSymbolProvider(settings, model, provider);
Symbol symbol = decorated.toSymbol(service);

assertThat(symbol.getName(), equalTo("FirstNotCapitalizedClient"));
Expand All @@ -63,9 +63,9 @@ public void testRestNotCapitalizedServiceId() {
.unwrap();
Shape service = model.expectShape((ShapeId.from("smithy.example#OriginalName")));
AwsServiceIdIntegration integration = new AwsServiceIdIntegration();
SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model);
SymbolProvider decorated = integration.decorateSymbolProvider(
new TypeScriptSettings(), model, provider);
TypeScriptSettings settings = new TypeScriptSettings();
SymbolProvider provider = TypeScriptCodegenPlugin.createSymbolProvider(model, settings);
SymbolProvider decorated = integration.decorateSymbolProvider(settings, model, provider);
Symbol symbol = decorated.toSymbol(service);

assertThat(symbol.getName(), equalTo("RestNotCapitalizedClient"));
Expand Down