-
Notifications
You must be signed in to change notification settings - Fork 618
docs(upgrading): add generate-clients doc dependencies #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(upgrading): add generate-clients doc dependencies #2224
Conversation
d3e716e
to
55f87a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change: Can "It requires" be changed to follow "Follow steps found at: url" as it is already under prerequisites section.
I also changed the title to follow the semantic pull request rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! The requires
in no needed as it's already under Prerequisite
sectioin.
Codecov Report
@@ Coverage Diff @@
## main #2224 +/- ##
===========================================
+ Coverage 47.92% 79.45% +31.53%
===========================================
Files 535 366 -169
Lines 33253 15324 -17929
Branches 8241 3310 -4931
===========================================
- Hits 15937 12176 -3761
+ Misses 17316 3148 -14168 Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Documentation to mention dependency on smithy-typescript.
Issue #1291
Description
Add link in documentation text for the dependency smithy-typescript
Testing
The link to external dependency install steps works, as has been noted by myself and @ajredniwja
Additional context
The dependency on smithy-typescript crosses over from the usual node/javascript package ecosystem into java/maven/gradle used by smithy. It's also for an internal/developer step in the codebase. As such it is not an automated install of the dependency.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.