Skip to content

docs(client-ses): use await in async/await sample #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pratikpc
Copy link
Contributor

@pratikpc pratikpc commented Apr 10, 2021

Issue

Fix #2231

Description

What does this implement/fix? Explain your changes.
Async await example in client-ses README does not use async/await

Testing

async/await command would need await to get the expected result based on the sample


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 161a9a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member

trivikr commented Apr 13, 2021

Thank you @pratikpc for finding this issue, and adding a PR to fix it.
This fix is required in codegen for all clients. I cherry-picked your commit, and posted fix for all clients in #2243

@trivikr trivikr closed this Apr 13, 2021
@pratikpc pratikpc deleted the patch-1 branch April 13, 2021 14:11
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(clients) async/await example does not use async await
3 participants