Skip to content

fix(client-sts): disable stsClient cache #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(client-sts): disable stsClient cache #2268

wants to merge 1 commit into from

Conversation

cuyl
Copy link

@cuyl cuyl commented Apr 16, 2021

sourceCreds can be expired so we can't cache the STSClient instance.

@AllanZhengYP AllanZhengYP self-requested a review April 16, 2021 19:46
@AllanZhengYP
Copy link
Contributor

Hi @cuyl Thank you for bringing this to attention. I will take a look at this.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@4e99b8d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f0887e7 differs from pull request most recent head a2c5996. Consider uploading reports for the commit a2c5996 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2268   +/-   ##
=======================================
  Coverage        ?   59.90%           
=======================================
  Files           ?      467           
  Lines           ?    24583           
  Branches        ?     5834           
=======================================
  Hits            ?    14726           
  Misses          ?     9857           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e99b8d...a2c5996. Read the comment docs.

- sourceCreds can be expired
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 36d3407
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP
Copy link
Contributor

Closing this PR as it has been replaced by #2353

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants