Skip to content

docs(clients): generate examples of making request with bare-bones clients #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Description

  • Generate examples of making API call with bare-bone clients and commands.
  • Mark logSensitiveLog() as internal API

example:
Screen Shot 2021-05-03 at 9 26 58 AM


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c888af2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage        ?   60.05%           
=======================================
  Files           ?      472           
  Lines           ?    24833           
  Branches        ?     5881           
=======================================
  Hits            ?    14913           
  Misses          ?     9920           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c888af2...6280dd6. Read the comment docs.

@AllanZhengYP
Copy link
Contributor Author

Need to add the imports to the examples like bellow:

import {Client, Command} from "@aws-sdk/client-foo"; // ES Modules import
// const {Client, Command} = require("@aws-sdk/client-foo"); // CommonJS import

@trivikr trivikr changed the title docs(clients): generate examples of making request with bare-bone clients docs(clients): generate examples of making request with bare-bones clients May 3, 2021
@AllanZhengYP AllanZhengYP requested a review from trivikr May 4, 2021 23:03
@AllanZhengYP AllanZhengYP merged commit 2165d4a into aws:main May 5, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants