Skip to content

fix(clients): properly decode SQS messages #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pauldraper
Copy link
Contributor

Fixes #2362.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@4904f6a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2364   +/-   ##
=======================================
  Coverage        ?   58.88%           
=======================================
  Files           ?      482           
  Lines           ?    25928           
  Branches        ?     6154           
=======================================
  Hits            ?    15267           
  Misses          ?    10661           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4904f6a...84f7dcd. Read the comment docs.

@alexforsyth
Copy link
Contributor

@pauldraper Thanks so much for the PR. Just as a heads up, we shouldn't generally be making updates to /clients this is generated code using our code generator: smithy-typescript

@trivikr
Copy link
Member

trivikr commented May 14, 2021

Superceded by #2381

@trivikr trivikr closed this May 14, 2021
@pauldraper
Copy link
Contributor Author

Thanks for the real fix :)

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZA̡͊͠͝LGΌ causes "Invalid MD5 checksum on messages"
4 participants