Skip to content

chore(middleware-retry): move exportable constants to configurations #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 28, 2021

Issue

Follow-up to #2435

Description

Moves constants to constants.ts in middleware-retry.
This is part of cleanup before introducing adaptive retry strategy.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c7371b6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 729e02f differs from pull request most recent head dba7a36. Consider uploading reports for the commit dba7a36 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2442   +/-   ##
=======================================
  Coverage        ?   58.95%           
=======================================
  Files           ?      488           
  Lines           ?    26116           
  Branches        ?     6203           
=======================================
  Hits            ?    15397           
  Misses          ?    10719           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7371b6...dba7a36. Read the comment docs.

@trivikr trivikr changed the title chore(middleware-retry): move constants to constants.ts chore(middleware-retry): move exportable constants to configurations May 28, 2021
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@trivikr trivikr merged commit e2fd6e3 into aws:main May 28, 2021
@trivikr trivikr deleted the middleware-retry-constants branch May 28, 2021 15:24
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request May 28, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants