Skip to content

chore(codegen): use function supplier in RuntimeClientPlugin #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 7, 2021

Issue

Refs: smithy-lang/smithy-typescript#353

Description

uses function supplier in RuntimeClientPlugin instead of static function parameters.

Testing

Verified that yarn generate-clients did not update the RuntimeClientPlugin functions in clients.

Additional context

Refs: smithy-lang/smithy-typescript#352


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP June 7, 2021 13:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@cec0692). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7b89099 differs from pull request most recent head ca062d4. Consider uploading reports for the commit ca062d4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2470   +/-   ##
=======================================
  Coverage        ?   59.54%           
=======================================
  Files           ?      493           
  Lines           ?    26357           
  Branches        ?     6261           
=======================================
  Hits            ?    15695           
  Misses          ?    10662           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec0692...ca062d4. Read the comment docs.

@trivikr trivikr force-pushed the use-runtime-client-plugin-function-params-supplier branch from 7b89099 to 52576ef Compare June 24, 2021 21:30
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants