Skip to content

feat(credential-provider-sso): support sso credential when resolving shared credential file #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jul 15, 2021

Resolves #2504

Description

  • Add SSO credential support to INI credential provider. As a result, the SDK can follow the assume role chain specified in the shared ~/.aws/credentials file, and assume the role derived from the SSO credential.
  • The SSO credential provider supports specifying SSO parameters(e.g. start URL, account id, assume role name, region) in-line from the constructor parameters. If none of them is supplied, the provider will fall back to resolve the specified profile in the shared ~/.aws/credentials file. NOTE: The SSO credential provider itself doesn't support assume role chain. It will fail if specified profile doesn't use a SSO credential
  • Create an internal package @aws-sdk/util-credentials to host all the shared credential utilities. This is to optimize the dependency topology.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review July 15, 2021 22:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@f239221). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2583   +/-   ##
=======================================
  Coverage        ?   60.33%           
=======================================
  Files           ?      513           
  Lines           ?    27392           
  Branches        ?     6586           
=======================================
  Hits            ?    16527           
  Misses          ?    10865           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f239221...da3db40. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 6c3d066
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 9480e70 into aws:main Jul 16, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use AWS SSO with assume role
4 participants