Skip to content

chore(smithy-client): emitWarningIfUnsupportedVersion #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 26, 2021

Issue

Refs: #2594 (comment)

Description

Create emitWarningIfUnsupportedVersion in smithy-client.
This file would be called from runtimeConfig in clients.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the emit-warning-node-version branch from 733b113 to 8f2e868 Compare July 26, 2021 18:02
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5c9152a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 733b113 differs from pull request most recent head 8f2e868. Consider uploading reports for the commit 8f2e868 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2619   +/-   ##
=======================================
  Coverage        ?   60.62%           
=======================================
  Files           ?      517           
  Lines           ?    27655           
  Branches        ?     6798           
=======================================
  Hits            ?    16766           
  Misses          ?    10889           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9152a...8f2e868. Read the comment docs.

@trivikr trivikr force-pushed the emit-warning-node-version branch from b7da8ce to feefed1 Compare July 26, 2021 18:46
@trivikr trivikr force-pushed the emit-warning-node-version branch from feefed1 to ce5b6ef Compare July 26, 2021 18:50
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: ce5b6ef
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 5a865f0 into aws:main Jul 26, 2021
@trivikr trivikr deleted the emit-warning-node-version branch July 26, 2021 22:23
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants