Skip to content

fix: set skew offset in catch block upon failure #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kgoedecke
Copy link
Contributor

Issue

#2208

Description

The time skew wasn't correct since the await block got rejected upon a request that has a skewed time. Hence we need to correct the time inside a catch block for it to succeed on the next try.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@af23369). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2664   +/-   ##
=======================================
  Coverage        ?   60.60%           
=======================================
  Files           ?      516           
  Lines           ?    27780           
  Branches        ?     6826           
=======================================
  Hits            ?    16836           
  Misses          ?    10944           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af23369...c175b63. Read the comment docs.

@AllanZhengYP AllanZhengYP requested a review from trivikr August 13, 2021 17:42
@AllanZhengYP
Copy link
Contributor

@kgoedecke Looks like the existing unit tests for clock skew is failing. Can you take a look at them?

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: c175b63
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member

trivikr commented Aug 17, 2021

Thank you @kgoedecke for posting this PR.

Your commit was cherry-picked in subsequent PRs as explained in #2208 (comment)

This PR will be closed when the fix is posted upstream.

@trivikr trivikr marked this pull request as draft August 17, 2021 21:08
@trivikr
Copy link
Member

trivikr commented Aug 19, 2021

Superceded by #2686

@trivikr trivikr closed this Aug 19, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants