chore: remove email ids from package.json #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 265 265
Lines 6070 6070
Branches 1364 1364
=======================================
Hits 5547 5547
Misses 523 523
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Can you also remove the email from the generator?
see here: https://github.com/aws/aws-sdk-js-v3/blob/master/packages/package-generator/src/ModuleGenerator.ts#L83
|
Removed email from generator in commit a4f9601 |
AllanZhengYP
approved these changes
Jun 1, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Removing email ID, as we've started receiving spam emails.
Users can always create issues on GitHub
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.