Skip to content

chore(appintegrations): re-introduce CORS retry headers #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 14, 2021

Issue

Follow-up to #2658

Description

Re-introduces CORS retry headers for appintegrations

Testing

Verified in internal ticket that headers are supported for appintegrations.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the reintroduce-retry-headers branch from 645cb52 to 882c0a7 Compare October 7, 2021 23:00
@codecov-commenter
Copy link

Codecov Report

Merging #2787 (645cb52) into main (7f5567b) will increase coverage by 1.58%.
The diff coverage is n/a.

❗ Current head 645cb52 differs from pull request most recent head 882c0a7. Consider uploading reports for the commit 882c0a7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2787      +/-   ##
==========================================
+ Coverage   58.57%   60.16%   +1.58%     
==========================================
  Files         558      548      -10     
  Lines       30249    28585    -1664     
  Branches     7443     6997     -446     
==========================================
- Hits        17719    17197     -522     
+ Misses      12530    11388    -1142     
Impacted Files Coverage Δ
packages/util-user-agent-node/src/index.ts 90.00% <0.00%> (-1.67%) ⬇️
packages/middleware-signing/src/configurations.ts 88.37% <0.00%> (-0.52%) ⬇️
packages/signature-v4/src/utilDate.ts 90.00% <0.00%> (ø)
packages/signature-v4/src/constants.ts 100.00% <0.00%> (ø)
packages/util-base64-node/src/index.ts 100.00% <0.00%> (ø)
packages/signature-v4/src/SignatureV4.ts 100.00% <0.00%> (ø)
packages/signature-v4/src/cloneRequest.ts 100.00% <0.00%> (ø)
packages/util-base64-browser/src/index.ts 100.00% <0.00%> (ø)
packages/s3-request-presigner/src/presigner.ts 100.00% <0.00%> (ø)
packages/signature-v4/src/credentialDerivation.ts 100.00% <0.00%> (ø)
... and 612 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5567b...882c0a7. Read the comment docs.

@trivikr trivikr requested a review from AllanZhengYP October 11, 2021 18:26
@trivikr trivikr merged commit 57dbe3b into aws:main Oct 11, 2021
@trivikr trivikr deleted the reintroduce-retry-headers branch October 11, 2021 18:27
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants