Skip to content

chore(tsconfig): remove default and redundant options #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 27, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 24, 2021

Issue

Internal JS-2845

Description

Cleans up tsconfig by removing default and redundant options

Testing

Integration tests are successful:

$ yarn test:integration
yarn run v1.22.11
$ jest --config jest.config.integ.js --passWithNoTests
 PASS  clients/client-transcribe-streaming/test/index.integ.spec.ts (31.608 s)
  TranscribeStream client
    ✓ should stream the transcript (28774 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        32.093 s
Ran all test suites.
Done in 32.76s.

$ yarn test:integration-legacy
yarn run v1.22.11
$ cucumber-js --fail-fast
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m34.657s
Done in 98.88s.

The remaining tests will be run in as a dry-run release after merging.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title feat(tsconfig): remove default and redundant options chore(tsconfig): remove default and redundant options Sep 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #2824 (b2a8d63) into main (033a4d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2824   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files         554      554           
  Lines       28885    28885           
  Branches     7072     7072           
=======================================
  Hits        17452    17452           
  Misses      11433    11433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033a4d8...b2a8d63. Read the comment docs.

@trivikr trivikr force-pushed the clean-tsconfig branch 2 times, most recently from bcfc327 to d5d36b4 Compare September 24, 2021 20:14
@trivikr trivikr marked this pull request as ready for review September 24, 2021 21:10
ts-jest uses root tsconfig.json, and options related to strictness
and helpers break multiple unit tests.
@trivikr trivikr merged commit 6dfabb9 into aws:main Sep 27, 2021
@trivikr trivikr deleted the clean-tsconfig branch September 27, 2021 16:51
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants