Skip to content

chore(codegen): use bare-bones and aggregated instead of modular/non-modular #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2021
Merged

chore(codegen): use bare-bones and aggregated instead of modular/non-modular #2925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5cd2df
chore: add BareBones to DocClientGenerator
trivikr Oct 24, 2021
329d37b
chore: use Aggregated for DocFullClientGenerator
trivikr Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../src/main/java/software/amazon/smithy/aws/typescript/codegen/AddDocumentClientPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ public void writeAdditionalFiles(
}

writerFactory.accept(String.format("%s%s.ts", docClientPrefix, DocumentClientUtils.CLIENT_NAME),
writer -> new DocumentClientGenerator(settings, model, symbolProvider, writer).run());
writer -> new DocumentBareBonesClientGenerator(settings, model, symbolProvider, writer).run());

writerFactory.accept(String.format("%s%s.ts", docClientPrefix, DocumentClientUtils.CLIENT_FULL_NAME),
writer -> new DocumentFullClientGenerator(settings, model, symbolProvider, writer).run());
writer -> new DocumentAggregatedClientGenerator(settings, model, symbolProvider, writer).run());

writerFactory.accept(String.format("%sindex.ts", docClientPrefix), writer -> {
for (OperationShape operationOverriden: overridenOperationsList) {
Expand Down
4 changes: 2 additions & 2 deletions .../codegen/DocumentFullClientGenerator.java → ...en/DocumentAggregatedClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import software.amazon.smithy.utils.StringUtils;

@SmithyInternalApi
final class DocumentFullClientGenerator implements Runnable {
final class DocumentAggregatedClientGenerator implements Runnable {
static final String CLIENT_CONFIG_SECTION = "client_config";
static final String CLIENT_PROPERTIES_SECTION = "client_properties";
static final String CLIENT_CONSTRUCTOR_SECTION = "client_constructor";
Expand All @@ -44,7 +44,7 @@ final class DocumentFullClientGenerator implements Runnable {
private final Symbol symbol;
private final String serviceName;

DocumentFullClientGenerator(
DocumentAggregatedClientGenerator(
TypeScriptSettings settings,
Model model,
SymbolProvider symbolProvider,
Expand Down
4 changes: 2 additions & 2 deletions ...ript/codegen/DocumentClientGenerator.java → ...gen/DocumentBareBonesClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import software.amazon.smithy.utils.SmithyInternalApi;

@SmithyInternalApi
final class DocumentClientGenerator implements Runnable {
final class DocumentBareBonesClientGenerator implements Runnable {
static final String CLIENT_CONFIG_SECTION = "client_config";
static final String CLIENT_PROPERTIES_SECTION = "client_properties";
static final String CLIENT_CONSTRUCTOR_SECTION = "client_constructor";
Expand All @@ -46,7 +46,7 @@ final class DocumentClientGenerator implements Runnable {
private final String serviceName;
private final String configType;

DocumentClientGenerator(
DocumentBareBonesClientGenerator(
TypeScriptSettings settings,
Model model,
SymbolProvider symbolProvider,
Expand Down