Skip to content

chore(clients): populate regionRegex in partitionHash #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 26, 2021

Issue

Internal JS-2904

Description

Populates regionRegex in partitionHash.
The regionRegex is required to read signingRegion from hostname.

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #2933 (ede4aeb) into main (74e25df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2933   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         558      558           
  Lines       30249    30249           
  Branches     7443     7443           
=======================================
  Hits        17719    17719           
  Misses      12530    12530           
Impacted Files Coverage Δ
...lients/client-lex-runtime-service/src/endpoints.ts 100.00% <ø> (ø)
clients/client-mediastore-data/src/endpoints.ts 100.00% <ø> (ø)
clients/client-s3-control/src/endpoints.ts 100.00% <ø> (ø)
clients/client-sts/src/endpoints.ts 100.00% <ø> (ø)
...ig-resolver/src/regionInfo/getResolvedPartition.ts 100.00% <ø> (ø)
protocol_tests/aws-ec2/src/endpoints.ts 100.00% <ø> (ø)
protocol_tests/aws-json-10/src/endpoints.ts 100.00% <ø> (ø)
protocol_tests/aws-json/src/endpoints.ts 100.00% <ø> (ø)
protocol_tests/aws-query/src/endpoints.ts 100.00% <ø> (ø)
protocol_tests/aws-restjson/src/endpoints.ts 100.00% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e25df...ede4aeb. Read the comment docs.

@trivikr trivikr merged commit 5e1d297 into aws:main Oct 26, 2021
@trivikr trivikr deleted the partition-hash-regionregex branch October 26, 2021 17:09
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants