Skip to content

chore(middleware-bucket-endpoint): use booleanSelector from node-config-provider #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 28, 2021

Issue

Use booleanSelector introduced in #2941

Note: This PR will be made ready once fix in #2945 is merged. PR is ready!

Description

Uses booleanSelector from node-config-provider for:

  • NODE_USE_ARN_REGION_CONFIG_OPTIONS
  • NODE_DISABLE_MULTIREGION_ACCESS_POINT_CONFIG_OPTIONS

Testing

Unit tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #2946 (2c4d7d4) into main (abe4ed9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 2c4d7d4 differs from pull request most recent head 89b9a81. Consider uploading reports for the commit 89b9a81 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
+ Coverage   58.60%   58.63%   +0.02%     
==========================================
  Files         561      563       +2     
  Lines       30272    30262      -10     
  Branches     7452     7440      -12     
==========================================
+ Hits        17742    17743       +1     
+ Misses      12530    12519      -11     
Impacted Files Coverage Δ
...s/middleware-bucket-endpoint/src/configurations.ts 92.30% <ø> (+22.30%) ⬆️
.../NodeDisableMultiregionAccessPointConfigOptions.ts 100.00% <100.00%> (ø)
...cket-endpoint/src/NodeUseArnRegionConfigOptions.ts 100.00% <100.00%> (ø)
packages/middleware-bucket-endpoint/src/index.ts 100.00% <100.00%> (ø)
...ests-restxml/src/commands/XmlMapsXmlNameCommand.ts
...txml/src/commands/HttpPayloadWithXmlNameCommand.ts
...tests-restxml/src/commands/XmlNamespacesCommand.ts
...otocoltests-restxml/src/commands/XmlMapsCommand.ts
...src/commands/IgnoreQueryParamsInResponseCommand.ts
...sts-restxml/src/commands/FlattenedXmlMapCommand.ts
... and 402 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe4ed9...89b9a81. Read the comment docs.

@trivikr trivikr force-pushed the use-boolean-selector branch from 44bf28d to 2c4d7d4 Compare October 28, 2021 16:57
@trivikr trivikr marked this pull request as ready for review October 28, 2021 16:58
@trivikr trivikr force-pushed the use-boolean-selector branch from 2c4d7d4 to 89b9a81 Compare October 29, 2021 15:02
@trivikr trivikr requested a review from AllanZhengYP October 29, 2021 15:18
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants