Skip to content

test(size-benchmark): generate benchmark and validation for package size #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Nov 11, 2021

Description

More details in the README

TODOs in follow-up PRs:

  • Update test scopes to include popular AWS services
  • Add test to GitHub Action or CodeBuild -- GitHub Action maybe too slow because this requires building many packages.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner November 11, 2021 23:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #3018 (f396850) into main (179afb9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files         567      567           
  Lines       30360    30360           
  Branches     7483     7483           
=======================================
  Hits        17841    17841           
  Misses      12519    12519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179afb9...f396850. Read the comment docs.

test(size-benchmark): complete webpack size with size-limit

test(size-benchmark): split code in multiple files

test(size-benchmark): populate esbuild size

test(size-benchmark): use webpack api instead of sizelimit for more accuracy

test(size-benchmark): populate rollup size

test(size-benchmark): populate size report

test(benchmark-size): uadd script to launch benchmark

test(size-benchmark): implement validator class

test(size-benchmark): add README

test(benchmark-test): add scope config to skip bundler tests

chore(benchmark-test): bump to Listr2

test(benchmark-size): refactor folder layout

test(benchmark-test): fix generating new report

chore(benchmark): regenerate report
@AllanZhengYP AllanZhengYP merged commit 82745a5 into aws:main Nov 17, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants