Skip to content

test(endpoint): mention fips/dualstack config in title #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 18, 2021

Issue

Helps debug issues like CI failures in be5740f (#3039)

Description

Mention fips/dualstack config in test title

Testing

Before:

...
    ✓ testing "client-s3-control" with region: us-gov-east-1
    ✓ testing "client-s3-control" with region: us-gov-east-1
    ✓ testing "client-s3-control" with region: us-gov-east-1
    ✓ testing "client-s3-control" with region: us-gov-east-1
...

After:

...
    ✓ testing "client-s3-control" with {"region":"us-gov-east-1","useFipsEndpoint":false,"useDualstackEndpoint":false}
    ✓ testing "client-s3-control" with {"region":"us-gov-east-1","useFipsEndpoint":false,"useDualstackEndpoint":true}
    ✓ testing "client-s3-control" with {"region":"us-gov-east-1","useFipsEndpoint":true,"useDualstackEndpoint":false}
    ✓ testing "client-s3-control" with {"region":"us-gov-east-1","useFipsEndpoint":true,"useDualstackEndpoint":true}
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner November 18, 2021 21:32
@codecov-commenter
Copy link

Codecov Report

Merging #3041 (9a9fb74) into main (e497f38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3041   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files         567      567           
  Lines       30360    30360           
  Branches     7482     7482           
=======================================
  Hits        17841    17841           
  Misses      12519    12519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e497f38...9a9fb74. Read the comment docs.

@trivikr trivikr merged commit bcfb45b into aws:main Nov 19, 2021
@trivikr trivikr deleted the improve-endpoint-test-title branch November 19, 2021 01:22
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants