Skip to content

test(e2e-legacy): fix incorrect client imports #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Issue

followup: #3033

Description

Some import statement was missed in last PR. this change fixes it

Testing

node node_modules/.bin/cucumber-js
..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m41.643s

Additional context

Previous PR did not test in current cucumber test script(test:integration:legacy script), it only tested on test:integration:legacy:since:release script


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner November 19, 2021 20:39
@AllanZhengYP AllanZhengYP requested a review from trivikr November 19, 2021 20:41
@codecov-commenter
Copy link

Codecov Report

Merging #3047 (039f038) into main (6ae48e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3047   +/-   ##
=======================================
  Coverage   58.76%   58.76%           
=======================================
  Files         567      567           
  Lines       30360    30360           
  Branches     7482     7482           
=======================================
  Hits        17841    17841           
  Misses      12519    12519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae48e9...039f038. Read the comment docs.

@AllanZhengYP AllanZhengYP changed the title test(integration): fix incorrect client imports test(e2e-legacy): fix incorrect client imports Nov 19, 2021
@AllanZhengYP AllanZhengYP merged commit cd45aee into aws:main Nov 19, 2021
@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants