Skip to content

chore(aws-protocoltests-restjson): enable RestJsonNoInputAndOutput #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 23, 2021

Issue

This test was disabled when updating clients in d1746ce (#2674)

The test was disabled as it was incorrect in smithy.
It was fixed by writing server only test RestJsonNoInputAndOutputAllowsAccept in smithy-lang/smithy#935

Description

Enables RestJsonNoInputAndOutput test in aws-protocoltests-restjson

Testing

Protocol tests are successful.

Additional context

This PR will be rebased from main and made ready after smithy is bumped to 1.14.x in #3053


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the enable-rest-json-no-input-output branch from 7ac9b74 to 9084220 Compare November 23, 2021 17:56
@codecov-commenter
Copy link

Codecov Report

Merging #3060 (7ac9b74) into main (ba14b3c) will decrease coverage by 0.01%.
The diff coverage is 56.96%.

❗ Current head 7ac9b74 differs from pull request most recent head 9084220. Consider uploading reports for the commit 9084220 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   58.76%   58.75%   -0.02%     
==========================================
  Files         567      571       +4     
  Lines       30360    30604     +244     
  Branches     7482     7536      +54     
==========================================
+ Hits        17841    17980     +139     
- Misses      12519    12624     +105     
Impacted Files Coverage Δ
...otocoltests-restjson/src/RestJsonProtocolClient.ts 92.00% <ø> (ø)
...tocoltests-restjson/src/protocols/Aws_restJson1.ts 43.72% <34.45%> (-0.41%) ⬇️
...-restjson/src/commands/TestBodyStructureCommand.ts 90.47% <90.47%> (ø)
...ests-restjson/src/commands/TestNoPayloadCommand.ts 90.47% <90.47%> (ø)
...ts-restjson/src/commands/TestPayloadBlobCommand.ts 90.47% <90.47%> (ø)
...stjson/src/commands/TestPayloadStructureCommand.ts 90.47% <90.47%> (ø)
.../aws-protocoltests-restjson/src/models/models_0.ts 90.26% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfa8bf...9084220. Read the comment docs.

@trivikr trivikr marked this pull request as ready for review November 23, 2021 17:57
@trivikr trivikr requested a review from a team as a code owner November 23, 2021 17:57
@trivikr trivikr merged commit 566b9d3 into aws:main Nov 24, 2021
@trivikr trivikr deleted the enable-rest-json-no-input-output branch November 24, 2021 00:40
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants