Skip to content

chore(clients): populate default variant only if hostname exists #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 10, 2022

Issue

Improvement noticed while working on #3172

Description

Populate default variant only if hostname exists

Testing

Verified that endpoints tests are successful

$ yarn test:functional
yarn run v1.22.17
$ jest --config tests/functional/jest.config.js
 PASS  tests/functional/signing-names/index.spec.ts
 PASS  tests/functional/endpoints/index.spec.ts

Test Suites: 2 passed, 2 total
Tests:       1506 passed, 1506 total
Snapshots:   0 total
Time:        3.752 s, estimated 7 s
Ran all test suites.
Done in 4.63s.

Additional context

This PR will be made ready once #3172 is merged.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 10, 2022 22:06
@trivikr trivikr marked this pull request as draft January 10, 2022 22:06
@trivikr trivikr force-pushed the populate-default-variant-only-if-necessary branch from 73f3e11 to 5008034 Compare January 10, 2022 23:40
@trivikr trivikr force-pushed the populate-default-variant-only-if-necessary branch from 5008034 to b3af5cf Compare January 10, 2022 23:46
@trivikr trivikr marked this pull request as ready for review January 10, 2022 23:46
@trivikr trivikr merged commit 9bf8f1d into aws:main Jan 11, 2022
@trivikr trivikr deleted the populate-default-variant-only-if-necessary branch January 11, 2022 01:07
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants