Skip to content

chore(clients): run builds concurrently #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 15, 2022

Issue

Closes #3196

Description

Testing

CI

There are no improvements in running build:all but definite improvements if individual packages need to be built during development.

build:all

Before:

$ time ./node_modules/.bin/lerna run build
...
14235.33s user 385.16s system 3283% cpu 7:25.24 total

After:

$ time ./node_modules/.bin/lerna run build
...
14577.44s user 396.23s system 3379% cpu 7:23.04 total
client-ec2

Before:

$ client-ec2> yarn build
...
Done in 45.95s.

After:

$ client-ec2> yarn build
...
Done in 17.19s.

Additional context

This PR will be made ready once #3197 is merged. Ready!
Changes in smithy-ts smithy-lang/smithy-typescript#498


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the clients-concurrently branch from 6d9e4b7 to c5ebf0f Compare January 18, 2022 16:49
@trivikr trivikr marked this pull request as ready for review January 18, 2022 16:53
@trivikr trivikr requested a review from a team as a code owner January 18, 2022 16:53
@trivikr trivikr requested a review from AllanZhengYP January 18, 2022 17:33
@trivikr trivikr merged commit 4ae5af5 into aws:main Jan 19, 2022
@trivikr trivikr deleted the clients-concurrently branch January 19, 2022 00:05
trivikr added a commit that referenced this pull request Jan 19, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use concurrently to run tsc concurrently in build step
2 participants