Skip to content

chore(package.json): rename pre user scripts and explicitly call them #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 25, 2022

Issue

Closes #3248

Description

  • removes pretest:all, and calls build:all from test:all
  • renames pretest:e2e to build:e2e, and calls it from test:e2e

Testing

  • CI (which runs test:all)
  • Verified that pretest:e2e runs build:e2e.
$ yarn test:e2e
yarn run v1.22.17
$ yarn build:e2e && node ./tests/e2e/index.js
$ yarn build:crypto-dependencies && lerna run --scope '@aws-sdk/{client-cloudformation,karma-credential-loader}' --include-dependencies build
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 25, 2022 20:21
@trivikr trivikr merged commit 921e9b4 into aws:main Jan 25, 2022
@trivikr trivikr deleted the remove-pre-post-user-scripts branch January 25, 2022 21:07
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename user scripts which use pre and post hooks and explicitly call them from other scripts which use them
2 participants