Skip to content

chore(benchmark-size): update current size of credential-provider-ini package #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Ref: V517378088

The current size benchmark testing failed with:

Updating 45 rows in the report /codebuild/output/src176440339/src/aws-sdk-js-v3/benchmark/size/report.md
Report is updated, validating the new result with the limit configurations.
Error: Limit validation has failed: 
@aws-sdk/credential-provider-ini package publishSize is 69734.4, increases by more than 10%
    at Object.updateReport (/codebuild/output/src176440339/src/aws-sdk-js-v3/scripts/benchmark-size/runner/reporter/index.ts:133:11)
    at /codebuild/output/src176440339/src/aws-sdk-js-v3/scripts/benchmark-size/runner/index.ts:119:3
    at step (/codebuild/output/src176440339/src/aws-sdk-js-v3/scripts/benchmark-size/runner/index.ts:44:23)
    at Object.next (/codebuild/output/src176440339/src/aws-sdk-js-v3/scripts/benchmark-size/runner/index.ts:25:53)
    at fulfilled (/codebuild/output/src176440339/src/aws-sdk-js-v3/scripts/benchmark-size/runner/index.ts:16:58)
error Command failed with exit code 1.

The size increase expected to introduced by #3289

Description

  • Update the current size report to the latest size of @aws-sdk/credential-provider-ini.
  • Show better log message of the yarn test:size script.

Testing

Test Log
dev-dsk-zheallan-2c-2c672b83 % yarn test:size --since last_release
yarn run v1.22.17
$ cd scripts/benchmark-size/runner && yarn && ./cli.ts --since last_release
[1/4] Resolving packages...
success Already up-to-date.
starting generating size report for changed packages
publishing locally the changed package since last release.
the package versions will be the actual version up with a patch version and preid "ci".
published 397 packages
loading test scopes from /local/home/zheallan/workspace/aws-sdk-js-v3/scripts/benchmark-size/scope.json
loaded 55 local packages within test scope
Found 45 packages in the defined scope have size test scope.
✔ @aws-sdk/client-lambda
✔ @aws-sdk/client-dynamodb
✔ @aws-sdk/client-kinesis
✔ @aws-sdk/client-firehose
✔ @aws-sdk/client-cognito-identity
✔ @aws-sdk/client-s3
✔ @aws-sdk/client-app-mesh
✔ @aws-sdk/client-pinpoint
✔ @aws-sdk/client-cognito-sync
✔ @aws-sdk/client-ssm
✔ @aws-sdk/client-ec2
✔ @aws-sdk/client-sts
✔ @aws-sdk/client-cloudformation
✔ @aws-sdk/client-codepipeline
✔ @aws-sdk/client-cloudwatch
✔ @aws-sdk/client-cognito-identity-provider
✔ @aws-sdk/client-sns
✔ @aws-sdk/client-iam
✔ @aws-sdk/client-kms
✔ @aws-sdk/client-codecommit
✔ @aws-sdk/client-application-insights
✔ @aws-sdk/client-auto-scaling
✔ @aws-sdk/client-resource-groups-tagging-api
✔ @aws-sdk/client-codebuild
✔ @aws-sdk/client-efs
✔ @aws-sdk/client-glue
✔ @aws-sdk/client-athena
✔ @aws-sdk/client-cloudhsm-v2
✔ @aws-sdk/client-ses
✔ @aws-sdk/client-xray
✔ @aws-sdk/client-codedeploy
✔ @aws-sdk/client-eventbridge
✔ @aws-sdk/client-cloudwatch-logs
✔ @aws-sdk/client-opsworks
✔ @aws-sdk/credential-providers
✔ @aws-sdk/credential-provider-cognito-identity
✔ @aws-sdk/credential-provider-ini
✔ @aws-sdk/credential-provider-node
✔ @aws-sdk/credential-provider-process
✔ @aws-sdk/credential-provider-sso
✔ @aws-sdk/polly-request-presigner
✔ @aws-sdk/s3-presigned-post
✔ @aws-sdk/s3-request-presigner
✔ @aws-sdk/lib-dynamodb
✔ @aws-sdk/lib-storage
Updating 45 rows in the report /local/home/zheallan/workspace/aws-sdk-js-v3/benchmark/size/report.md
Report is updated, validating the new result with the limit configurations.
Done in 473.06s.

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner February 10, 2022 21:49
@AllanZhengYP AllanZhengYP merged commit e2b7b25 into aws:main Feb 10, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants