Skip to content

fix(scripts): disable downleveling for private workspaces #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 11, 2022

Issue

Attempt to fix JS-3107

Description

Skips downleveling for private packages

Testing

Verified that downleveling happens in non-private package (say client-s3) and not in private package (say client-echo-service):

Before
$ aws-echo-service> ls dist-types          
commands                EchoService.d.ts  models     runtimeConfig.browser.d.ts  runtimeConfig.native.d.ts
EchoServiceClient.d.ts  index.d.ts        protocols  runtimeConfig.d.ts          runtimeConfig.shared.d.ts

$ client-s3> ls dist-types 
commands        models      runtimeConfig.browser.d.ts  runtimeConfig.shared.d.ts  waiters
endpoints.d.ts  pagination  runtimeConfig.d.ts          S3Client.d.ts
index.d.ts      protocols   runtimeConfig.native.d.ts   S3.d.ts
After
$ aws-echo-service> ls dist-types          
commands                EchoService.d.ts  models     runtimeConfig.browser.d.ts  runtimeConfig.native.d.ts
EchoServiceClient.d.ts  index.d.ts        protocols  runtimeConfig.d.ts          runtimeConfig.shared.d.ts

$ client-s3> ls dist-types
commands        models      runtimeConfig.browser.d.ts  runtimeConfig.shared.d.ts  ts3.4
endpoints.d.ts  pagination  runtimeConfig.d.ts          S3Client.d.ts              waiters
index.d.ts      protocols   runtimeConfig.native.d.ts   S3.d.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 11, 2022 18:17
@trivikr
Copy link
Member Author

trivikr commented Feb 11, 2022

Replaced by #3307

@trivikr trivikr closed this Feb 11, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
@trivikr trivikr deleted the skip-private-downlevel branch August 26, 2022 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant