test: only include packages updates since master

[trivikr]

Issue #, if available:
Fixes: #335

Description of changes:
While running tests, only include packages that have been updated since master
Doc: https://github.com/lerna/lerna/tree/master/core/filter-options#--since-ref
If there are no changes, it takes less than 1 min to run yarn test (yarn-test.log)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[trivikr]

Travis CI build succeeds after adding --passWithNoTests for test-ci, but there's no coverage info posted by codecov

[trivikr]

I ran commits in this PR on top of #317 and noticed that it's running pretest on all packages and not the ones changed since master (yarn-test-ci.log vs yarn-test.log)

Expected behavior: Run tests only on node-http-handler

[trivikr]

For code in PR #317, I ran the following commands:

• lerna ls --json (lerna-ls.txt)
  • 468 packages
• lerna ls --json --since master (lerna-ls-since-master.txt)
  • 185 packages
• lerna ls --json --since master --include-filtered-dependents --include-filtered-dependencies (lerna-ls-since-master-include.txt)
  • 259 packages

[trivikr]

For code in PR #333, I ran the following commands:

• lerna ls (lerna-ls.txt)
  • 468 packages
• lerna ls --since master
  • 0 packages
• lerna ls --since master --include-filtered-dependents --include-filtered-dependencies (lerna-ls-since-master-include.txt)
  • 1 package

[trivikr]

lerna ls ignore private packages, so it was listing only one package in #336 (comment)

Confirmed that pretest runs on all dependencies of the edited packages.
For PR #333, confirmed that tests are run on 5 packages (2 edited packages, and 3 dependencies)
(yarn-test.log)

[trivikr]

Reintroduced --include-filtered-dependents
Confirmed that pretest runs on all dependents and dependencies of the edited packages.

• For PR chore(deps-dev): bump @types/prettier from 1.16.4 to 1.18.2 #333, confirmed that tests are run on 5 packages (2 edited packages, and 3 dependencies) (yarn-test.log)
• For PR feat: Node.js HTTP/2 Handler #317, confirmed that tests are run on (1 edited package, and 258 dependencies)

[trivikr]

Findings while going through lerna codebase:

• the dependents and dependencies are added in (get-filtered-packages)
• Definitions of dependencies and dependents in PackageGraph
  • Dependencies: if packageA depended on packageB graph.addDependencies([packageA]) would return [packageA, packageB].
  • Dependents: if packageC depended on packageD graph.addDependents([packageD]) would return [packageD, packageC].

[trivikr]

ToDo: verify CI runs in:

• chore: remove greenkeeper #331 - no packages are edited
• chore(deps-dev): bump @types/prettier from 1.16.4 to 1.18.2 #333 - devDependencies edited in package-generator and service-types-generator
• feat: Node.js HTTP/2 Handler #317 - new file in node-http-handler

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.