chore(signature-v4): using ES2017 on node to achieve better performance #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
fix/signv4-perf
branch
2 times, most recently
from
8126b16 to
fbd855e
Compare
* keep using es5 for browser to ensure to compatibility; * ship with ES module for browser bundler
CodeBuild is a lot faster and has longer timeout than Travis CI
AllanZhengYP
force-pushed
the
fix/signv4-perf
branch
from
f5f8e76 to
562a9a6
Compare
trivikr
approved these changes
Sep 18, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have confirmed with Webpack. If set
targettoweb, the bundler will pick up browser compatible es5 code in ESmodule. If settargettonode, the bundler will pick up the faster es2017 code in commonJS module.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.