Skip to content

revert: chore(client-kinesis): switch to H2 handler #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

revert: chore(client-kinesis): switch to H2 handler #3616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions clients/client-kinesis/jest.integ.config.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion clients/client-kinesis/src/runtimeConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
NODE_RETRY_MODE_CONFIG_OPTIONS,
} from "@aws-sdk/middleware-retry";
import { loadConfig as loadNodeConfig } from "@aws-sdk/node-config-provider";
import { NodeHttp2Handler as RequestHandler, streamCollector } from "@aws-sdk/node-http-handler";
import { NodeHttpHandler as RequestHandler, streamCollector } from "@aws-sdk/node-http-handler";
import { fromBase64, toBase64 } from "@aws-sdk/util-base64-node";
import { calculateBodyLength } from "@aws-sdk/util-body-length-node";
import { defaultUserAgent } from "@aws-sdk/util-user-agent-node";
Expand Down
15 changes: 0 additions & 15 deletions clients/client-kinesis/test/Kinesis.integ.spec.ts
View file
Open in desktop

This file was deleted.

13 changes: 7 additions & 6 deletions ...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddHttp2Dependency.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@
package software.amazon.smithy.aws.typescript.codegen;

import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.function.Consumer;
import software.amazon.smithy.aws.traits.protocols.AwsProtocolTrait;
import software.amazon.smithy.aws.traits.ServiceTrait;
import software.amazon.smithy.codegen.core.SymbolProvider;
import software.amazon.smithy.model.Model;
import software.amazon.smithy.model.shapes.ServiceShape;
Expand All @@ -39,7 +38,8 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
TypeScriptSettings settings,
Model model,
SymbolProvider symbolProvider,
LanguageTarget target) {
LanguageTarget target
) {
if (!isHttp2Applicable(settings.getService(model))) {
return Collections.emptyMap();
}
Expand All @@ -57,8 +57,9 @@ public Map<String, Consumer<TypeScriptWriter>> getRuntimeConfigWriters(
}

private static boolean isHttp2Applicable(ServiceShape service) {
List<String> eventStreamFlag = service.getTrait(AwsProtocolTrait.class)
.map(AwsProtocolTrait::getEventStreamHttp).orElse(ListUtils.of());
return eventStreamFlag.contains("h2");
String serviceId = service.getTrait(ServiceTrait.class).map(ServiceTrait::getSdkId).orElse("");
// TODO: Add "Kinesis" service to http2 applicable, but blocked by potential breaking change.
// Reference: https://github.com/aws/aws-sdk-js-v3/issues/1206
return ListUtils.of("Lex Runtime V2", "Transcribe Streaming").contains(serviceId);
}
}